MLE-25554 Excluding fragile tests on PR builds#1039
Conversation
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR excludes fragile tests from PR builds and simplifies the deployment process by removing a redundant mlWaitTillReady call. The changes target improved build stability by temporarily skipping problematic document data movement tests in PR builds while still running them in other build contexts.
- Excludes fragile tests (documents-data-movement-*) from PR builds
- Removes redundant
mlWaitTillReadycall and sleep - Converts shell script from single quotes to double quotes for variable interpolation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jenkinsfile
Outdated
| def runTests(excludeFragileTests = false) { | ||
| def mochaGlob = excludeFragileTests ? | ||
| 'test-basic/!(documents-data-movement-*).js' : |
There was a problem hiding this comment.
The excluded test pattern 'documents-data-movement-*' is hardcoded. Consider extracting this to a pipeline parameter or configuration variable to make it easier to maintain and modify the list of excluded tests without code changes.
| def runTests(excludeFragileTests = false) { | |
| def mochaGlob = excludeFragileTests ? | |
| 'test-basic/!(documents-data-movement-*).js' : | |
| def runTests(excludeFragileTests = false, excludedTestPattern = 'documents-data-movement-*') { | |
| def mochaGlob = excludeFragileTests ? | |
| "test-basic/!(${excludedTestPattern}).js" : |
Also removed the second mlWaitTillReady call based on updates to ml-gradle
rjrudin
force-pushed
the
feature/fragile-tests
branch
from
0be1956 to
91d26d3
Compare
2 participants
Also removed the second mlWaitTillReady call based on updates to ml-gradle